Skip to content

Remove phpdbg from coverage target#405

Merged
f3l1x merged 1 commit intocontributte:masterfrom
ohmyfelix:chore/php-coverage-target
Mar 14, 2026
Merged

Remove phpdbg from coverage target#405
f3l1x merged 1 commit intocontributte:masterfrom
ohmyfelix:chore/php-coverage-target

Conversation

@ohmyfelix
Copy link
Contributor

Summary

Replace -p phpdbg with -p php in the Makefile coverage target so this repository follows the org-wide coverage runner migration tracked in contributte/contributte#73.

Motivation

phpdbg is being removed from Contributte coverage targets. This keeps the starter skeleton aligned with the shared direction and avoids new repositories inheriting the old runner.

Changes

  • switch the coverage target in Makefile from phpdbg to php
  • keep the rest of the tester coverage command unchanged

Testing

  • Tests pass locally
  • CI passes
  • Manual verification attempted: make coverage
  • Local make coverage currently fails in this environment because php has no Xdebug or PCOV extension loaded, and coverage with -p php requires one of those drivers.

Use the regular PHP binary for the Makefile coverage target to align this repository with the org-wide coverage migration tracked in contributte/contributte#73.
@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@a4ffa1a). Learn more about missing BASE report.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #405   +/-   ##
=========================================
  Coverage          ?   33.33%           
=========================================
  Files             ?        5           
  Lines             ?       42           
  Branches          ?        0           
=========================================
  Hits              ?       14           
  Misses            ?       28           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@f3l1x f3l1x marked this pull request as ready for review March 14, 2026 11:10
@f3l1x f3l1x merged commit 4b6f34e into contributte:master Mar 14, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants